fix init_parser_plugins for python 3.12 #425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reformatted the ValueError in init_parser_plugins to conform with black's formatting standard
jzohrab
requested changes
May 19, 2024
|
|
||
| if version_info.major == 3 and version_info.minor in (8, 9, 10, 11): | ||
| custom_parser_eps = entry_points().get('lute.plugin.parse') | ||
| elif version_info.major == 3 and version_info.minor == 12: |
There was a problem hiding this comment.
Perhaps we should change this to >= 12. Granted, we can't know what the API will be in version 3.13+, but maybe we can play fast and loose with this one, and just bump up the CI checks on GitHub as versions come out.
| for custom_parser_ep in custom_parser_eps: | ||
| if _is_valid(custom_parser_ep.load()): | ||
| __LUTE_PARSERS__[custom_parser_ep.name] = custom_parser_ep.load() | ||
| else: | ||
| raise ValueError( | ||
| f"{custom_parser_ep.name} is not a subclass of AbstractParser" | ||
| f"{custom_parser_ep.name} is not a a subclass of AbstractParser" |
There was a problem hiding this comment.
I removed the "a a" before, and here it's added again, any reason? :-)
|
Code included in updated #426 , cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for users on python 3.12, which broke because the entry points no longer return as a dictionary in that version, so
.select(group='lute.plugin.parse')is used instead.Additional logic was added to handle version differences, both in terms of fetching the entry points from the method and processing them (a catch for None was added)
Solves: